Merged
Conversation
|
👋 Thanks for assigning @joostjager as a reviewer! |
- We fix an oversight introduced in 9977903 where we switched `Cargo.toml` to use local dependencies instead of pointing to an appropriate upstream commit - We account for Splicing-related events - We account for `KeysManager` taking a new flag for v2-payment-key derivation.
tnull
force-pushed
the
2025-10-bump-to-latest-LDK-splicing
branch
from
ef393bf to
2276157
Compare
joostjager
approved these changes
Oct 13, 2025
| LdkEvent::SplicePending { .. } => { | ||
| debug_assert!( | ||
| false, | ||
| "We currently don't support splicing, so this event should never be emitted." |
Contributor
There was a problem hiding this comment.
Just to double check - no splicing api is exposed in ldk-node and therefore this should never happen? I don't know the api, but is it possible for the counterparty to initiate this and get us to move along?
Collaborator
Author
There was a problem hiding this comment.
Yes, there is a new reject_inbound_splices on UserConfig that defaults to true. So we'll have to manually opt into splicing support as part of the integration PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cargo.tomlto use local dependencies instead of pointing to an appropriate upstream commitKeysManagertaking a new flag for v2-payment-key derivation.